Thread (10 messages) 10 messages, 4 authors, 2013-09-18

[PATCH 2/2] arm: zynq: Enable arm_global_timer

From: Sören Brinkmann <hidden>
Date: 2013-09-18 17:05:31
Also in: linux-devicetree, lkml

On Sun, Sep 15, 2013 at 01:40:36PM +0100, Grant Likely wrote:
On Thu, 12 Sep 2013 09:50:40 -0700, Soren Brinkmann [off-list ref] wrote:
quoted
Zynq is based on an ARM Cortex-A9 MPCore, which features the
arm_global_timer in its SCU. Therefore enable the timer for Zynq.

Signed-off-by: Soren Brinkmann <redacted>
---
 arch/arm/boot/dts/zynq-7000.dtsi | 8 ++++++++
 arch/arm/mach-zynq/Kconfig       | 1 +
 2 files changed, 9 insertions(+)
diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
index e32b92b..eaacb39 100644
--- a/arch/arm/boot/dts/zynq-7000.dtsi
+++ b/arch/arm/boot/dts/zynq-7000.dtsi
@@ -92,6 +92,14 @@
 			};
 		};
 
+		global_timer: global_timer at f8f00200 {
Nit: node names and property names use '-' not '_'. Plus the generic
names principle suggests the node should be names 'timer' not
'global_timer'. The following would be fine:
That is really good to know. When I wrote this line, I read through a
couple of other dtses and was unable to identify a consistent system
behind node/label names.
		global_timer: timer at f8f00200 {
All right, I'll change it to this.

	
	Thanks,
	S?ren
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help