Hi Tomasz!

On Fri, Aug 30, 2013 at 5:20 PM, Tomasz Figa [off-list ref] wrote:

quoted

+Required properties:
+- compatible : "tl,trusted-foundations"
+- version-major : major version number of Trusted Foundations firmware
+- version-minor: minor version number of Trusted Foundations firmware

Hmm, maybe you could simply define a single version property that could
have multiple cells? Like:

        firmware {
                compatible = "tl,trusted-foundations";
                version = <2 8>;
        };

I'm fine this way too, but do we have other bindings that use the same
scheme? What is the general convention for version number bindings?

quoted

+       This option allows the kernel to invoke the secure monitor

whenever

quoted

+       required on devices using Trusted Foundations.
+
+       Devices using Trusted Foundations should pass a device tree
containing +    a node compatible with "tl,trusted-foundations" to
signal the presence +   of the secure monitor.

What about pointing to the documentation file instead?

Yes, that would make more sense.

quoted

+void of_register_trusted_foundations(void)
+{
+     struct device_node *node;
+
+     node = of_find_compatible_node(NULL, NULL, "tl,trusted-

foundations");

nit:
        if (!node)
                return;

Fixed, thanks.

quoted

+static inline void register_trusted_foundations(
+                                struct

trusted_foundations_platform_data *pd)

quoted

+{
+     pr_crit("No support for Trusted Foundations, stopping...\n");
+     BUG();

Hmm, why not simply panic()?

Fixed that too.

Thanks for the review!
Alex.