[PATCH v5 1/8] usb: phy: omap-control: Get rid of platform data

Hi Thomas,

On 08/20/2013 06:04 PM, thomas.langer at lantiq.com wrote:

Hello Roger,

this will not work!

Roger Quadros wrote on 2013-08-20:

quoted

-	struct omap_control_usb_platform_data *pdata =
-			dev_get_platdata(&pdev->dev);
+
+	if (np) {
+		of_property_read_u32(np, "ti,type", &control_usb->type);

here you are dereferencing control_usb

quoted

+	} else {
+		/* We only support DT boot */
+		return -EINVAL;
+	}

 	control_usb = devm_kzalloc(&pdev->dev, sizeof(*control_usb),
 		GFP_KERNEL);

and here it is allocated!

Good catch :).
The problem is eliminated by other patches in this series, so tests ran fine.
But I'll fix this one.

cheers,
-roger