[PATCH v6 13/20] pwm: Add new pwm-samsung driver
From: Andrew Bresticker <hidden>
Date: 2013-08-07 19:35:42
Also in:
linux-pwm, linux-samsung-soc
From: Andrew Bresticker <hidden>
Date: 2013-08-07 19:35:42
Also in:
linux-pwm, linux-samsung-soc
Hi Tomasz,
+#ifndef CONFIG_CLKSRC_SAMSUNG_PWM +/* + * PWM block is shared between pwm-samsung and samsung_pwm_timer drivers + * and some registers need access synchronization. If both drivers are + * compiled in, the spinlock is defined in the clocksource driver, + * otherwise following definition is used. + * + * Currently we do not need any more complex synchronization method + * because all the supported SoCs contain only one instance of the PWM + * IP. Should this change, both drivers will need to be modified to + * properly synchronize accesses to particular instances. + */ +static DEFINE_SPINLOCK(samsung_pwm_lock);
Shouldn't this not be static? It's declared in clocksource/samsung_pwm.h whether or not the samsung_pwm_timer is compiled in or not. Thanks, Andrew