On 08/05/2013 03:06 PM, Sebastian Hesselbarth wrote:

On 08/05/13 13:59, Mark Brown wrote:

quoted

On Sun, Aug 04, 2013 at 11:45:30PM +0200, Sebastian Hesselbarth wrote:

quoted

On 08/04/2013 09:21 PM, Russell King - ARM Linux wrote:

quoted

quoted

                 .name = "S/PDIF1",
                 .stream_name = "IEC958 Playback",
                 .platform_name = "mvebu-audio.1",
                 .cpu_dai_name = "mvebu-audio.1",
                 .codec_dai_name = "dit-hifi",
                 .codec_name = "spdif-dit",

quoted

Not a big deal for DT. I suggest to have a "audio-codecs" property that
link CPU DAI to codec(s). One thing, I have noticed is that currently
you need to supply both codec_name (or DT node) _and_ codec_dai_name.
For that it would be helpful, if ASoC supplies helpers to get the DAI
by index and use phandle with args here.

This should follow the same pattern as the other board bindings.

Mark,

looking at e.g. nvidia,tegra-audio-*.txt bindings, I guess you are
proposing to have a new binding for every SoC/codec/board combination?
Also, you should have seen "ASoC: fsl: Add S/PDIF machine driver", which
is - again - proposing a new binding for fsl with spdif "codec".

You really want me to go the same way or is there any "other board
binding" I should follow?

In my opinion having different bindings for each board is not a good idea.
Having a common set of property names will allow us to factor out the
parsing to the ASoC core instead of doing this by hand for each board driver.

quoted

quoted

i2s1: audio-controller at b0000 {
    compatible = "marvell,dove-i2s";
    reg = <0xb0000 0x2345>;
    audio-codecs = <&spdif 0>;
};

No, things are glued together using the machine driver - again, look at
how all the other systems work.  The wiring on the board can get
interesting enough to need a binding of its own, for very simple
bindings that should just be pointing to a generic driver.

And that is what will be true for almost all codecs we hook up on
Marvell SoCs. The audio controller is very simple with only mute
control available. We need to connect either i2s or spdif or both to
any codec and the codecs output. The codecs is determined by phandle
and the output (codec_dai_name) could be determined by the phandle's
arg, e.g. 0 for the first codec_dai provided.

Kuninori Morimoto started working on a xlate callback for CODECs and DAIs
some time ago[1]. If nobody else is going to pick this up I'm probably going
to continue his work on this.

- Lars

[1]
http://mailman.alsa-project.org/pipermail/alsa-devel/2013-February/059788.html