On 08/06/2013 05:07 PM, Michal Nazarewicz wrote:

On Tue, Aug 06 2013, Rob Herring wrote:

quoted

quoted

quoted

quoted

+static void reserved_mem_release_device_from_dt(struct device *dev)
+{
+       struct reserved_mem *region = get_dma_memory_region(dev);
+       if (!region)
+               return;
+       if (!region->cma)

if (region && !region->cma)

!region case is handled two lines above, so no need to check if region
is not null.

I think Rob's suggestion was to replace two 'if' statements with a single
one, which makes sense.


Thanks,
Sylwester