[PATCH RFC v2 5/5] spmi: document the PMIC arbiter SPMI bindings
From: Stephen Warren <hidden>
Date: 2013-08-23 21:56:04
Also in:
linux-arm-msm, lkml
On 08/09/2013 02:37 PM, Josh Cartwright wrote: Patch description?
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt b/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt
+Required properties: +- compatible : should be "qcom,spmi-pmic-arb". +- reg-names : should be "core", "intr", "cnfg"
+- reg : offset and length of the PMIC Arbiter Core register map. +- reg : offset and length of the PMIC Arbiter Interrupt controller register map. +- reg : offset and length of the PMIC Arbiter Configuration register map.
This seems like it's defining the "reg" property 3 times each with a different meaning. It'd be better to say something like: reg : register specifier. Must contain 3 entries, in the following order: core registers, interrupt register, configuration registers.
+ qcom,spmi at fc4c0000 {...
+ qcom,pm8841 at 4 {Node names typically don't include a vendor prefix. For the first instance above, I think just "spmi at fc4c0000" or even just "spmi" would be appropriate here; the latter being best in the case where there's only 1 SPMI controller and hence no need to include the unit address for uniqueness.