Thread (10 messages) 10 messages, 4 authors, 2013-08-27

[PATCH] pinctrl: Pass all configs to driver on pin_config_set()

From: Linus Walleij <hidden>
Date: 2013-08-21 22:14:05
Also in: linux-mips, lkml

Hi Sherman,

On Fri, Aug 16, 2013 at 12:42 AM, Sherman Yin [off-list ref] wrote:
When setting pin configuration in the pinctrl framework, pin_config_set() or
pin_config_group_set() is called in a loop to set one configuration at a time
for the specified pin or group.

This patch 1) removes the loop and 2) changes the API to pass the whole pin
config array to the driver.  It is now up to the driver to loop through the
configs.  This allows the driver to potentially combine configs and reduce the
number of writes to pin config registers.

Signed-off-by: Sherman Yin <redacted>
Reviewed-by: Christian Daudt <redacted>
Reviewed-by: Matt Porter <redacted>
Change-Id: I99cbfa2ae7b774456eb71edb276711b1ddcd42c8
---
Please refer to the discussion with Linus W. "[PATCH] ARM: Adds pin config API
to set all configs in one function" here:

http://lists.infradead.org/pipermail/linux-arm-kernel/2013-May/166567.html

All c files changed have been build-tested to verify the change compiles and
that the corresponding .o are successfully generated.
Good work! This is obviously the right thing to do and it's looking
very good.

Right now this does not apply to my "devel" branch, so I'd like you
to rebase on that right now. (This is what will go into v3.12).

This is also late in the development cycle so I believe this is going to
be v3.13 material unless there are more release candidates.

You can also hold on until after the v3.12 merge window and then
rebase it and we'll merge it as a first patch in the v3.13 development
cycle.

What do you say?

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help