On 16/08/13 23:14, Benjamin Herrenschmidt wrote:

On Fri, 2013-08-16 at 18:39 +0100, Sudeep KarkadaNagesha wrote:

quoted

+#ifdef CONFIG_PPC
+               /* Check for historical "ibm,ppc-interrupt-server#s" property
+                * for thread ids on PowerPC. If it doesn't exist fallback to
+                * standard "reg" property.
+                */
+               if (__of_find_n_match_cpu_property(cpun,
+                               "ibm,ppc-interrupt-server#s", cpu, thread))
+                       return cpun;
+#endif

It's not "historical". It's still very much in use and well defined in PAPR :-)

By historical, I meant it should not be used in future bindings.

Ah, sorry missed it in ePAPR, because its not under CPU node section.
What's more interesting is that ePAPR has it as an example for
non-standard property names :)

Can I mark it as custom/non-standard instead ? I mainly want to indicate
that we need to use 'reg' property and not introduce any more custom
properties for thread ids.

Can I add your ACK with this comment fixed ?

Regards,
Sudeep