[PATCH v5 1/2] ARM: davinci: da850: add DT node for ethernet
From: Sergei Shtylyov <hidden>
Date: 2013-08-16 18:46:09
Also in:
linux-devicetree, lkml, netdev
Hello. On 08/16/2013 06:11 PM, Lad, Prabhakar wrote:
From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Add ethernet device tree node information and pinmux for mii to da850 by providing interrupt details and local mac address.
Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com> --- arch/arm/boot/dts/da850-evm.dts | 5 +++++ arch/arm/boot/dts/da850.dtsi | 30 ++++++++++++++++++++++++++++++ 2 files changed, 35 insertions(+)
quoted hunk ↗ jump to hunk
diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts index 1f8cfdd..44f3fbc 100644 --- a/arch/arm/boot/dts/da850-evm.dts +++ b/arch/arm/boot/dts/da850-evm.dts@@ -96,6 +96,11 @@ pinctrl-0 = <&mdio_pins>; bus_freq = <2200000>; }; + ethernet: emac at 1e20000 {
Why label the node in the board file too?
quoted hunk ↗ jump to hunk
+ status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&mii_pins>; + }; }; nand_cs3 at 62000000 { status = "okay";diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi index d5138b4..a5d30d9 100644 --- a/arch/arm/boot/dts/da850.dtsi +++ b/arch/arm/boot/dts/da850.dtsi
[...]
quoted hunk ↗ jump to hunk
@@ -226,6 +242,20 @@ #size-cells = <0>; reg = <0x224000 0x1000>; }; + ethernet: emac at 1e20000 {
I said node should be named "ethernet", not labelled. You're the second
person that doesn't know the difference between the two. :-)
WBR, Sergei