[PATCH v3 1/5] ARM: add basic Trusted Foundations support
From: Stephen Warren <hidden>
Date: 2013-08-14 21:35:54
Also in:
linux-tegra, lkml
On 08/12/2013 08:29 PM, Alexandre Courbot wrote:
Trusted Foundations is a TrustZone-based secure monitor for ARM that can be invoked using a consistent smc-based API on all supported platforms. This patch adds initial basic support for Trusted Foundations using the ARM firmware API. Current features are limited to the ability to boot secondary processors.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/arm/firmware/tl,trusted-foundations.txt b/Documentation/devicetree/bindings/arm/firmware/tl,trusted-foundations.txt
+Trusted Foundations + +Boards that use the Trusted Foundations secure monitor can signal its +presence by declaring a node compatible with "tl,trusted-foundations" +(the name and location of the node does not matter). + +Required properties: +- compatible : "tl,trusted-foundations"
+- version : Must contain the version number string of the Trusted Foundation + firmware.
Can the version be queried at run-time from the firmware itself? If not, I wonder if we shouldn't instead encode the version number into the compatible value. Some comments on the exact format of the version property would be useful; from the example I assume it's "%02d.%02d" % (major_ver, minor_ver)?
quoted hunk ↗ jump to hunk
diff --git a/arch/arm/firmware/Kconfig b/arch/arm/firmware/Kconfig
+config ARCH_SUPPORTS_TRUSTED_FOUNDATIONS + bool
Shouldn't that be "config ARCH_SUPPORTS_FIRMWARE", since presumably in the future there will be more entries in the menu, and hence we want the menu to appear if any of those entries are useful?
+ +menu "Firmware options" + depends on ARCH_SUPPORTS_TRUSTED_FOUNDATIONS
Or perhaps that comment is more appropriate for that "depends".