[PATCH] RFC: interrupt consistency check for OF GPIO IRQs
From: Alexander Holler <hidden>
Date: 2013-08-02 15:36:35
Also in:
linux-omap, lkml
From: Alexander Holler <hidden>
Date: 2013-08-02 15:36:35
Also in:
linux-omap, lkml
Am 02.08.2013 11:57, schrieb Alexander Holler:
There must have been a bug in the patch too. I've also added that iinterrupt-parent stuff (with the same flags as used by the driver) and just have let the driver call request_threaded_irq(gpio_to_irq(gpio), flags); without the gpio_request()/input() before. And request_threaded_irq()
Not to forget that it would/will be a big problem, if you will forbid drivers to use gpio_request() when they use the gpio as irq (as it was/is necessary now). With my kernel 3.10.4 with some patches on top, I see # git grep gpio_to_irq | wc -l 678 So there are a lot of places where gpio_request(); gpio_direction_input() request_irq(); would have been changed to #ifdef CONFIG_OF_GPIO gpio_request(); gpio_direction_input() #endif request_irq(); to not fail during runtime (hopefully with some descriptive error message if it fails). Regards, Alexander Holler