[PATCH v3] net: Add MOXA ART SoCs ethernet driver

From: Joe Perches <joe@perches.com>
Date: Wed, 31 Jul 2013 11:56:38 -0700

quoted

+		if (ui & (RX_ERR | CRC_ERR | FTL | RUNT | RX_ODD_NB)) {
+			netdev_err(ndev, "packet error\n");

This is generally a bad idea as it can flood
the log.  It's probably better to remove it.
If you really want logging, then at least use
net_ratelimit().  Generally, the stats are
enough.

 ...

quoted

+			priv->stats.rx_dropped++;
+			priv->stats.rx_errors++;

[]

quoted

+static int moxart_mac_start_xmit(struct sk_buff *skb, struct net_device *ndev)

[]

quoted

+	if (txdesc->txdes0.ubit.tx_dma_own) {
+		netdev_err(ndev, "no TX space for packet\n");
+		priv->stats.tx_dropped++;

here too.

Agreed, these should not be logged, the statistics are sufficient.