Hi Mark,

On Sat, Jul 27, 2013 at 6:46 AM, Padma Venkat [off-list ref] wrote:

Hi Mark,

On Fri, Jul 26, 2013 at 8:49 PM, Mark Brown [off-list ref] wrote:

quoted

On Fri, Jul 26, 2013 at 07:06:51PM +0530, Padmavathi Venna wrote:

quoted

This patch adds wm8994 codec node on i2c bus1 and the required
regulator supplies and properties on smdk5420 board.

This isn't a device tree patch for WM8994, it's a patch for the
SMDK5420.

Yes. I will correct the subject.

quoted

quoted

+     vdd: fixed-regulator at 0 {
+             compatible = "regulator-fixed";
+             regulator-name = "vdd-supply";

These names look wrong - they should reflect the names in the schematic
as they're for human comprehensibility.  This may just be a case of
dropping the -supply.

When I posted the same patch for smdk5250, you asked me to club all
the same supply regulators. So I clubbed AVDD2 and CPVDD. So any other
better name for representing both supplies?

OK.

quoted

quoted

+             wm8994: wm8994 at 1a {
+                     compatible = "wlf,wm8994";
+                     reg = <0x1a>;
+
+                     gpio-controller;
+                     #gpio-cells = <2>;
+
+                     AVDD2-supply = <&vdd>;
+                     CPVDD-supply = <&vdd>;
+                     DBVDD-supply = <&dbvdd>;
+                     SPKVDD1-supply = <&spkvdd>;
+                     SPKVDD2-supply = <&spkvdd>;
+             };

It would be helpful to also add a clock binding (I posted a binding
documentation update the other day, it's in my tree now) but it's not
essential and I suspect it needs some work on the clock driver side
still.

OK. I will check this.

As per schemata, input clock to MCLK1 is an oscillator clock with
16.9MHz and MCLK2 not showing any input clock. So here I need to add a
fixed rate clock with 16.9MHz as MCLK1 in the smdk board file.

Is it correct?

Thanks
Padma