Thread (7 messages) 7 messages, 3 authors, 2013-07-31

[PATCHv2 3/3] fb: backlight: HX8357: Add HX8369 support

From: Alexandre Belloni <hidden>
Date: 2013-07-31 18:14:13
Also in: linux-fbdev, lkml

Hi,

On 26/07/2013 01:52, Jingoo Han wrote:
On Thursday, July 25, 2013 10:05 PM, Maxime Ripard wrote:
quoted
From: Alexandre Belloni <redacted>

Add support for the Himax HX8369 controller as it is quite similar to the
hx8357.

Signed-off-by: Alexandre Belloni <redacted>
Signed-off-by: Maxime Ripard <redacted>
Acked-by: Jingoo Han <redacted>
---
 drivers/video/backlight/hx8357.c | 221 ++++++++++++++++++++++++++++++++++++---
 1 file changed, 206 insertions(+), 15 deletions(-)
[....]
quoted
+	ret = hx8357_spi_write_byte(lcdev, HX8357_SET_DISPLAY_ON);
+	if (ret < 0)
+		return ret;
+
+	msleep(100);
Hi Maxime Ripard,

Could you add comment on this huge delay, too?
That one can actually be removed.

Regards,

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help