[PATCH 4/4] ARM: sun6i: Enable clock support in the DTSI

Hi,

El 31/07/13 05:11, kevin.z.m escribi?:

Hi, Maxime,
 

quoted

The problem is a bit more complex than that.

quoted

On the A31, the losc clock is actually a mux between an external
oscillator running at 32kHz, and the internal oscillator running at
667MHz, that would be scaled down.

quoted

Support for this mux is not quite there yet, since I've not seen any
documentation for it, but this would allow to just rearrange losc
parents and compatible when we will had such support.

 
I think there is some misunderstanding. All allwinner's platforms have
2 losc clock source. One is the external 32KHz oscillator, and the other
is internal 32kHz R/C circuit. The internal 32k R/C circuit can't provide
a very exact clock on 32KHz. The mux is just for select external osc or
internal
32KHz R/C. If there is no external 32kHz oscillator, we can replace it with
internal 32kHz R/C for some low speed but not exact clock requirement.

Thanks for the clarification :)

(snip)

quoted

quoted

+ ahb1_mux: ahb1_mux at 01c20054 {
+ #clock-cells = <0>;
+ compatible = "allwinner,sun6i-ahb1-mux-clk";
+ reg = <0x01c20054 0x4>;
+ clocks = <&osc32k>, <&osc24M>, <&axi>, <&pll6>;
+ };
+
+ ahb1: ahb1 at 01c20054 {
+ #clock-cells = <0>;
+ compatible = "allwinner,sun4i-ahb-clk";
+ reg = <0x01c20054 0x4>;
+ clocks = <&ahb1_mux>;
+ };

Depending on when this lands, I believe these two above could be merged
into one with the refactoring introduced on my patchset.

 
Since your patchset is still in RFC and we had no comments from Mike so
far, while this one looks pretty similar to the one we had before, I
guess the safest thing to do would be to rebase your patches on top of
this ones.

Ok, I'll do that.

Cheers,

Emilio