Thread (16 messages) 16 messages, 5 authors, 2014-03-06

[PATCH v4 6/8] wlcore: sdio: add wilink clock providers

From: Mike Turquette <hidden>
Date: 2013-07-30 22:35:41
Also in: linux-devicetree, linux-omap, linux-wireless, lkml

Quoting Luciano Coelho (2013-07-30 06:04:34)
quoted hunk ↗ jump to hunk
+static const struct of_device_id wlcore_sdio_of_clk_match_table[] = {
+       { .compatible = "ti,wilink-clock" },
+};
+
 static struct wl12xx_platform_data *wlcore_get_pdata_from_of(struct device *dev)
 {
        struct wl12xx_platform_data *pdata;
        struct device_node *np = dev->of_node;
+       struct device_node *clock_node;
 
        if (!np) {
                np = of_find_matching_node(NULL, dev->driver->of_match_table);
@@ -241,6 +247,9 @@ static struct wl12xx_platform_data *wlcore_get_pdata_from_of(struct device *dev)
                goto out_free;
        }
 
+       for_each_matching_node(clock_node, wlcore_sdio_of_clk_match_table)
+               of_fixed_clk_setup(clock_node);
Hi Luciano,

Any reason for establishing your own compatible string if you just plan
to use the fixed rate clock? You could just use "fixed-clock" compatible
in your DTS.

I will be posting patches this week which makes the fixed-rate clock a
proper driver and matches that compatible string to instantiate those
clocks. That means that your driver could probably remove the clock
setup code completely.

Regards,
Mike
+
        goto out;
 
 out_free:
-- 
1.8.3.2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help