[PATCH 3/4] rtc: omap: add rtc wakeup support to alarm events
From: Sekhar Nori <hidden>
Date: 2013-07-02 06:03:30
Also in:
linux-devicetree, linux-omap, lkml
On 6/28/2013 3:05 PM, Hebbar Gururaja wrote:
On some platforms (like AM33xx), a special register (RTC_IRQWAKEEN) is available to enable Alarm Wakeup feature. This register needs to be properly handled for the rtcwake to work properly. Platforms using such IP should set "ti,am3352-rtc" in rtc device dt compatibility node. Signed-off-by: Hebbar Gururaja <redacted> Cc: Grant Likely <redacted> Cc: Rob Herring <redacted> Cc: Rob Landley <redacted> Cc: Sekhar Nori <redacted> Cc: Kevin Hilman <redacted> Cc: Alessandro Zummo <redacted> Cc: rtc-linux at googlegroups.com Cc: devicetree-discuss at lists.ozlabs.org Cc: linux-doc at vger.kernel.org ---
[...]
quoted hunk ↗ jump to hunk
-#define OMAP_RTC_DATA_DA830_IDX 1 +#define OMAP_RTC_DATA_DA830_IDX 1 +#define OMAP_RTC_DATA_AM335X_IDX 2 static struct platform_device_id omap_rtc_devtype[] = { {@@ -309,6 +321,9 @@ static struct platform_device_id omap_rtc_devtype[] = { }, { .name = "da830-rtc", .driver_data = OMAP_RTC_HAS_KICKER, + }, { + .name = "am335x-rtc",
may be use am3352-rtc here just to keep the platform device name and of compatible in sync.
+ .driver_data = OMAP_RTC_HAS_KICKER | OMAP_RTC_HAS_IRQWAKEEN,
},
{},
It is better to use the index defined above in the static initialization
so they remain in sync.
...
[OMAP_RTC_DATA_DA830_IDX] = {
.name = "da830-rtc",
.driver_data = OMAP_RTC_HAS_KICKER,
},
...
quoted hunk ↗ jump to hunk
};@@ -318,6 +333,9 @@ static const struct of_device_id omap_rtc_of_match[] = { { .compatible = "ti,da830-rtc", .data = &omap_rtc_devtype[OMAP_RTC_DATA_DA830_IDX], }, + { .compatible = "ti,am3352-rtc", + .data = &omap_rtc_devtype[OMAP_RTC_DATA_AM335X_IDX], + }, {}, }; MODULE_DEVICE_TABLE(of, omap_rtc_of_match);
Apart from these minor issues, the patch looks good to me. Acked-by: Sekhar Nori <redacted> Thanks, Sekhar