On Thu, 2013-06-27 at 03:36 +0800, Stephen Warren wrote:

On 06/25/2013 03:27 AM, Joseph Lo wrote:

quoted

When the last CPU core in suspend, the CPU power rail can be turned off
by setting flags to flow controller. Then the flow controller will inform
PMC to turn off the CPU rail when the last CPU goes into suspend.

quoted

diff --git a/arch/arm/mach-tegra/pmc.c b/arch/arm/mach-tegra/pmc.c

quoted

+	/* Turn off CRAIL */
+	if (tegra_chip_id == TEGRA114) {

Presumably this new code is needed on Tegra114 and chips after it, so
not needing it is the exception? If so, I'd suggest the following
instead, so the code doesn't have to be modified for later chips:

switch (tegra_chip_id) {
case TEGRA20:
case TEGRA30:
	break;
default:
	the code you added
	break;
}

Indeed. Good idea. Will fix.

Thanks.