Thread (1 message) 1 message, 1 author, 2013-06-19
DORMANTno replies

[PATCH V3 05/11] USB: OHCI: Properly handle ohci-ep93xx suspend

From: viresh.kumar@linaro.org (Viresh Kumar)
Date: 2013-06-19 14:49:15

On 19 June 2013 20:12, Manjunath Goudar [off-list ref] wrote:
On 19 June 2013 18:13, Sergei Shtylyov [off-list ref]
quoted
On 19-06-2013 16:12, Manjunath Goudar wrote:
quoted
quoted
        struct usb_hcd *hcd = platform_get_drvdata(pdev);
        struct ohci_hcd *ohci = hcd_to_ohci(hcd);
+       bool    do_wakeup = device_may_wakeup(&pdev->dev);
+       int             ret;

   There was no need to use tabs here, didn't you see that here the
variables aren't aligned?
Instead of gmail you can use thunderbird mail there it is showing  proper
alignment.
First try to understand what the actual comment is. He isn't complaining
about bad alignment but as hcd and ohci aren't aligned with tabs, you
don't require to add tabs to do_wakeup and ret.

--
viresh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help