? 2013?06?08? 21:11, Fabio Estevam ??:

Hi Huang,

On Sat, Jun 8, 2013 at 5:04 AM, Huang Shijie[off-list ref]  wrote:

quoted

+       if (!uart_console(port)) {
+               retval = clk_prepare_enable(sport->clk_per);
+               if (retval)
+                       goto error_out1;
+               retval = clk_prepare_enable(sport->clk_ipg);
+               if (retval)
+                       goto error_out1;

Here you should not jump to "error_out1".

You should jump to a different label and disable the sport->clk_per clock.

yes. you are right.
I will fix it in the patch "serial: imx: enable the clocks for console"

thanks
Huang Shijie

This was also wrong in your previous patch.