Thread (1 message) 1 message, 1 author, 2013-06-03
DORMANTno replies

[PATCH 1/3] ARM: DTS: OMAP3: beagle/overo: mux console UART, enable wakeup

From: Kevin Hilman <hidden>
Date: 2013-06-03 21:26:42
Also in: linux-omap

Florian Vaussard [off-list ref] writes:
Hello Kevin,

On 06/01/2013 12:45 AM, Kevin Hilman wrote:
quoted
Ensure the console uart (UART3) on these boards is mux'd correctly, and
IO ring wakeup is enabled.

This is needed for serial console wakeups when using DT boot.

Signed-off-by: Kevin Hilman <redacted>
---
  arch/arm/boot/dts/omap3-beagle-xm.dts | 14 ++++++++++++++
  arch/arm/boot/dts/omap3-beagle.dts    | 12 ++++++++++++
  arch/arm/boot/dts/omap3-overo.dtsi    | 14 ++++++++++++++
  3 files changed, 40 insertions(+)
diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts b/arch/arm/boot/dts/omap3-beagle-xm.dts
index 3046d1f..ca067b0 100644
--- a/arch/arm/boot/dts/omap3-beagle-xm.dts
+++ b/arch/arm/boot/dts/omap3-beagle-xm.dts
@@ -126,3 +126,17 @@
  	mode = <3>;
  	power = <50>;
  };
+
+&omap3_pmx_core {
+	uart3_pins: pinmux_uart3_pins {
+		pinctrl-single,pins = <
+			0x16e 0x4100	/* uart3_rx_irrx.uart3_rx_irrx WAKEUP | INPUT | MODE0 */
+			0x170 0x0	/* uart3_tx_irtx.uart3_tx_irtx OUTPUT | MODE0 */
If you go through Benoit's tree, could you use the newly introduced
constants [1]? They are defined
in include/dt-bindings/pinctrl/omap.h. The above will look:

			0x16e (PIN_INPUT | WAKEUP_EVENT | MUX_MODE0)
/* uart3_rx_irrx.uart3_rx_irrx */
			0x170 (PIN_OUTPUT | MUX_MODE0)			/* uart3_tx_irtx.uart3_tx_irtx */
Excellent, thanks for the pointer.  I hadn't yet read through your
pre-processor series, but I really like the readability improvements.

I'll respin these on top of your changes.

Thanks,

Kevin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help