[PATCH v3 1/5] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs
From: s.nawrocki@samsung.com (Sylwester Nawrocki)
Date: 2013-06-28 10:11:31
Also in:
linux-devicetree, linux-fbdev, linux-media, linux-samsung-soc
On 06/28/2013 10:17 AM, Hui Wang wrote:
On 06/26/2013 11:02 PM, Sylwester Nawrocki wrote:quoted
Add a PHY provider driver for the Samsung S5P/Exynos SoC MIPI CSI-2 receiver and MIPI DSI transmitter DPHYs. Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> --- Changes since v2: - adapted to the generic PHY API v9: use phy_set/get_drvdata(), - fixed of_xlate callback to return ERR_PTR() instead of NULL, - namespace cleanup, put "GPL v2" as MODULE_LICENSE, removed pr_debug, - removed phy id check in __set_phy_state(). ---[...]quoted
+ + if (IS_EXYNOS_MIPI_DSIM_PHY_ID(id)) + reset = EXYNOS_MIPI_PHY_MRESETN; + else + reset = EXYNOS_MIPI_PHY_SRESETN; + + spin_lock_irqsave(&state->slock, flags);Sorry for one stupid question here, why do you use spin_lock_irqsave() rather than spin_lock(), I don't see the irq handler will use this spinlock anywhere in this c file.
Yes, there is no chance the PHY users could call the phy ops from within an interrupt context. Especially now when there is a per phy object mutex used in the PHY operation helpers. So I'll replace it with plain spin_lock/unlock. Thank you for the review. Regards, Sylwester