[PATCH V4 2/3] ARM: mmc: bcm281xx SDHCI driver
From: Christian Daudt <hidden>
Date: 2013-06-01 00:17:36
Also in:
linux-devicetree, linux-mmc
From: Christian Daudt <hidden>
Date: 2013-06-01 00:17:36
Also in:
linux-devicetree, linux-mmc
Hi Chris, On 13-05-31 09:15 AM, Chris Ball wrote:
Could you investigate replacing this section of code with a call to mmc_of_parse(), please? It should be able to replace your parsing and handling of bus-width, cd-gpios, wp-gpios, and non-removable (other than the initialization quirks specific to your hardware). I'd like to avoid every driver having its own DT parsing. Thanks, - Chris.
I looked into it and it can replace just about everything that our own
dt parsing code is doing. The only problem is with cd_gpio. If I call
mmc_of_parse, then it will install its own irq handler for cd gpio, and
our driver needs a different handler. the mmc irq handler can call a
card_event callback, but that is already pointing to sdhci_card_event.
So the only way I can use mmc_of_parse that I can see is by adding a
flag to it to skip cd_gpio parsing which only this driver will then set
to true. Any other ideas ?
Thanks,
csd