Thread (19 messages) 19 messages, 3 authors, 2013-07-01

[PATCHv3 5/8] ARM: mxs: dt: cfa10037: make hogpins grabbed by respective drivers

From: Maxime Ripard <hidden>
Date: 2013-06-29 07:05:35
Also in: lkml

Hi Alexandre

On Fri, Jun 28, 2013 at 03:02:54PM +0200, Alexandre Belloni wrote:
Signed-off-by: Alexandre Belloni <redacted>
Acked-by: Maxime Ripard <redacted>
With one minor comment, that applies to your other patches as well.
quoted hunk ↗ jump to hunk
---
 arch/arm/boot/dts/imx28-cfa10037.dts | 19 ++++++++++++++-----
 1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/arch/arm/boot/dts/imx28-cfa10037.dts b/arch/arm/boot/dts/imx28-cfa10037.dts
index c2ef3a3..182b99f 100644
--- a/arch/arm/boot/dts/imx28-cfa10037.dts
+++ b/arch/arm/boot/dts/imx28-cfa10037.dts
@@ -22,13 +22,19 @@
 	apb at 80000000 {
 		apbh at 80000000 {
 			pinctrl at 80018000 {
-				pinctrl-names = "default", "default";
-				pinctrl-1 = <&hog_pins_cfa10037>;
The pinctrl-name property isn't relevant since the 10036 patch. You
should probably have ordered them the other way around: first the
breakout board, then the 10036.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130629/8403a88c/attachment.sig>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help