On Thursday 20 June 2013, Chao Xie wrote:

On Wed, Jun 19, 2013 at 7:13 PM, Gerhard Sittig [off-list ref] wrote:

quoted

On Wed, Jun 19, 2013 at 16:38 +0800, Chao Xie wrote:

quoted

On Wed, Jun 19, 2013 at 4:22 PM, Marek Vasut [off-list ref] wrote:

quoted

quoted

Signed-off-by: Chao Xie <redacted>
[ ... ]

+++ b/Documentation/devicetree/bindings/input/pxa27x-keypad.txt

@@ -0,0 +1,60 @@
+* Marvell PXA Keypad controller
+
+Required Properties
+- compatible : should be "marvell,pxa27x-keypad"
+- reg : Address and length of the register set for the device
+- interrupts : The interrupt for the keypad controller
+- marvell,debounce-interval : How long time the key will be

Is there no generic prop name for this debounce interval?

I searched at drivers/input and Documents.
Two drivers use "debounce-interval", gpio-keys.c and stmpe-keypad.c.
They describe the meanings of "debounce-interval" at its own document file.
Some other drivers uses "xxx,debounce-delay-ms" or "debounce-delay-ms"
So it seems that there is no generic prop name for this debounce interval.

Actually there is, but under a different (more user friendly)
name:  See the 'debounce-delay-ms' property in
Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt
which gets referenced in the matrix_keypad_parse_dt() routine in
the drivers/input/keyboard/matrix_keypad.c source file.  Ah, your
last sentence mentions that fact.

But when you introduce DT support into an existing driver which
previously used platform data, then there is no problem with
backwards compatibility in .dts files.  So I suggest to go with
the "debounce-delay-ms" name since it better reflects to the .dts
author (hardware engineer) which unit the number is supposed to
be specified in.

So Arnd
What do you think? I am fine with either one.

debounce-delay-ms

	Arnd