On Monday 10 June 2013 14:52:38 Srinivas KANDAGATLA wrote:

On 10/06/13 14:16, Linus Walleij wrote:

quoted

On Mon, Jun 10, 2013 at 11:22 AM, Srinivas KANDAGATLA
[off-list ref] wrote:

quoted

This mfd driver provides higher level inialization routines for various
IPs like Ethernet, USB, PCIE, SATA and so on. Also it provides way to
get to syscfg registers via standard regmap api which is usefull for
drivers like pinctrl.

This patch adds support to ST System Configuration registers, which can
be configured by the drivers.

Signed-off-by: Srinivas Kandagatla <redacted>
CC: Stuart Menefy <redacted>
CC: Stephen Gallimore <redacted>
CC: Linus Walleij <redacted>
CC: Mark Brown <broonie@kernel.org>

What is this driver doing that drivers/mfd/syscon.c is not already
doing?

As of now, the driver is very much similar to syscon + some additional
functionality, but we are planning to use this file to add higher level
functions to configure different IPs like ethernet, usb, power, reset
and so on which are very much specific to ST System Configuration Registers.

I was expecting that you'd actually interface with the syscon code and
build on top, rather than copy it.

There are multiple ways of doing that, e.g. you could export a function
from syscon.c that you call to register the device node and then import
the regmap from syscon into your high-level driver again.

	Arnd