[PATCH 1/3] drivers: pinctrl sleep and idle states in the core
From: Stephen Warren <hidden>
Date: 2013-06-05 17:22:55
Also in:
lkml
On 06/05/2013 07:44 AM, Linus Walleij wrote:
From: Linus Walleij <redacted> If a device have sleep and idle states in addition to the default state, look up these in the core and stash them in the pinctrl state container. Add accessor functions for pinctrl consumers to put the pins into "default", "sleep" and "idle" states passing nothing but the struct device * affected. Solution suggested by Kevin Hilman, Mark Brown and Dmitry Torokhov in response to a patch series from Hebbar Gururaja.
quoted hunk ↗ jump to hunk
diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
+int pinctrl_pm_select_default_state(struct device *dev)
+int pinctrl_pm_select_sleep_state(struct device *dev)
+int pinctrl_pm_select_idle_state(struct device *dev)
The implementation of those 3 functions is basically identical. I'd be inclined to move it to a helper function, and just pass (dev, pins->xxx_state) to it.