FW: [PATCH 4/4] ARM: tegra: pcie: Enable PCIe controller on Cardhu

<Forwarding to bigger aliases>

Anybody aware of hang in r8169 driver over pcie interface mentioned at bottom of this mail?

-----Original Message-----
From: Jay Agarwal 
Sent: Tuesday, June 04, 2013 7:17 PM
To: 'Stephen Warren'
Cc: 'thierry.reding at avionic-design.de'
Subject: RE: [PATCH 4/4] ARM: tegra: pcie: Enable PCIe controller on Cardhu

quoted

quoted

quoted

quoted

On 05/31/2013 06:17 AM, Jay Agarwal wrote:

quoted

quoted

quoted

I have taken care of all your comments, but Ethernet 
device is not working

for me neither on cardhu nor harmony.

quoted

Could be related to my process or board, Currently 
debugging

this.

quoted

quoted

quoted

quoted

quoted

quoted

Are you talking about a PCIe-based Ethernet device on 
Harmony, or the one that's built into the board?

The on-board Ethernet device is USB, and should work fine 
already, and irrespective of any PCIe patches.

No I am talking about ethernet over PCIe interface.  There 
is no problem

with built-in ethernet over USB.

quoted

quoted

I have only tried an XHCI USB controller in the PCIe slot 
on Harmony, so I can't say if Ethernet not working is a 
regression or not. Does the Ethernet device work with just 
Thierry's patches and not

yours?

quoted

quoted

It does not work w/o any of my patches also.

Thierry,
Have you verified any ethernet card working on harmony?
I am using Broadcom Ethernet card with TIGON3 driver, but it 
does not

work although PCIe enumeration and driver probe looks fine as

attached.

quoted

quoted

quoted

Any idea?

Oh, one thing to consider here: PCIe interrupts don't work 
correctly when
LP2 is enabled, at least in the upstream kernel. It's 
something I've been trying to investigate, but haven't tracked down yet.

Anyway, you need to disable the LP2 CPU power management state 
for sure.
Hopefully this will solve the issue for you. One way to do 
this is the following patch, although we need a better 
solution before we can actually merge anything:

https://patchwork.kernel.org/patch/2525151/

Stephen,
This patch also did not resolve the issue although I do get 
"Disabling
LP2 cpuidle state..."  message in logs.

It stucks as below:

root at localhost:~# dhclient eth0
[ 1444.579544] smsc95xx 3-1.1:1.0 eth0: hardware isn't capable of 
remote wakeup [ 1444.587300] IPv6: ADDRCONF(NETDEV_UP): eth0: link 
is not ready

My system does not have ping command, so dhclient fails like below:
/sbin/dhclient-script: line 325: ping: command not found

So I provided static IP as : ifconfig eth0 <IP> but it also did not help.

 Actually sorry, I was using wrong Ethernet interface(eth0) on 
harmony, but correct one is eth1(over pcie interface) which works fine 
on Thierry's repo after applying patches to disable LP2.
Now I will try after applying my patches on both harmony and cardhu.

Ethernet is working on harmony is working w/ & a/o my patches but cardhu is hanging as below:

root at localhost:~# ifconfig eth0 10.19.65.115 [  102.525245] r8169 0000:03:00.0 eth0: unable to load firmware patch rtl_nic/rtl8168e-3.fw (-2) [  102.951516] r8169 0000:03:00.0 eth0: rtl_phyar_cond == 1 (loop: 20, delay: 25).
<System hangs here..>

1. Harmony is using Broadcom pcie Ethernet card and cardhu is using realtek one.
2. Enumeration and lspci seems to be fine though.
3. I tried applying similar patches for disabling LP2 for tegra 3 as well but it did not help.
4. Any idea/opinion?