Thread (29 messages) 29 messages, 7 authors, 2013-06-17

[PATCH 09/11] mmc: omap_hsmmc: enhance pinctrl support

From: Linus Walleij <hidden>
Date: 2013-06-04 07:11:03
Also in: linux-devicetree, linux-mmc, linux-omap, lkml

On Fri, May 31, 2013 at 12:13 PM, Hebbar Gururaja
[off-list ref] wrote:
Amend the hsmmc controller to optionally take a pin control handle and
set the state of the pins to:

- "default" on boot, resume and before performing a mmc transfer
- "idle" after initial default, after resume default, and after each
mmc/sd card access
- "sleep" on suspend()

By optionally putting the pins into sleep state in the suspend callback
we can accomplish two things.
- One is to minimize current leakage from pins and thus save power,
- second, we can prevent the IP from driving pins output in an
uncontrolled manner, which may happen if the power domain drops the
domain regulator.

If any of the above pin states are missing in dt, a warning message
about the missing state is displayed.
If certain pin-states are not available, to remove this warning message
pass respective state name with null phandler.

Signed-off-by: Hebbar Gururaja <redacted>
Cc: Balaji T K <redacted>
Cc: Chris Ball <redacted>
Cc: linux-mmc at vger.kernel.org
Cc: linux-omap at vger.kernel.org
This is perfectly correct.
Acked-by: Linus Walleij <redacted>

As the PM code seems to be similar across platforms I have had
loose plans to move this to the device core as well, but right now
I'm too busy with other things, and it can surely be refactored later.

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help