Hi Srinivas,

2013/6/3 Srinivas KANDAGATLA [off-list ref]:

On 03/06/13 04:51, Barry Song wrote:

quoted

did you see this one?

[PATCH v2] arm: prima2: use of_platform_populate instead of
of_platform_bus_probe
http://www.spinics.net/lists/arm-kernel/msg243710.html

Yes, I think this is a nice cleanup for simplest case. But Prima
platforms do much more checking at the same init level. An attempt to
get rid of postcore and early init calls might introduce this back.

You could solve both the early and postcore initcall issues by returning
instead of panic, and let every NON Prima platforms call this function.
Or
Do it the right way and clean it up.

I will leave it up to you to decide on how you want to fix the multi_v7
kernel issue.

i want to move sirfsoc_of_pwrc_init and sirfsoc_of_pwrc_init to
sirfsoc_pm_init as only suspend entries need them. then the result is
like:

 int __init sirfsoc_pm_init(void)
 {
+       sirfsoc_of_pwrc_init();
+       sirfsoc_memc_init();
        suspend_set_ops(&sirfsoc_pm_ops);
        return 0;
 }

@@ -98,7 +103,7 @@ static const struct of_device_id pwrc_ids[] = {
        {}
 };

Thanks,
srini

-barry