[PATCH-V2] ARM: AM33XX: Add missing .clkdm_name to clkdiv32k_ick clock

* Hiremath, Vaibhav [off-list ref] [130517 03:36]:

quoted

-----Original Message-----
From: Paul Walmsley [mailto:paul at pwsan.com]
Sent: Wednesday, March 27, 2013 11:15 PM
To: Tony Lindgren; Hiremath, Vaibhav
Cc: linux-omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org;
Nayak, Rajendra
Subject: Re: [PATCH-V2] ARM: AM33XX: Add missing .clkdm_name to
clkdiv32k_ick clock

On Wed, 27 Mar 2013, Vaibhav Hiremath wrote:

quoted

It is required to enable respective clock-domain before
enabling any clock/module inside that clock-domain.

During common-clock migration, .clkdm_name field got missed
for "clkdiv32k_ick" clock, which leaves "clk_24mhz_clkdm"
unused; so it will be disabled even if childs of this clock-domain
is enabled, which keeps child modules in idle mode.

This fixes the kernel crash observed on AM335xEVM-SK platform,
where clkdiv32_ick clock is being used as a gpio debounce clock
and since clkdiv32k_ick is in idle mode it leads to below crash -

Crash Log:
==========
[    2.598347] Unhandled fault: external abort on non-linefetch

(0x1028) at

quoted

0xfa1ac150
[    2.606434] Internal error: : 1028 [#1] SMP ARM
[    2.611207] Modules linked in:
[    2.614449] CPU: 0    Not tainted  (3.8.4-01382-g1f449cd-dirty #4)
[    2.620973] PC is at _set_gpio_debounce+0x60/0x104
[    2.626025] LR is at clk_enable+0x30/0x3c

Signed-off-by: Vaibhav Hiremath <redacted>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Paul Walmsley <paul@pwsan.com>
Cc: Rajendra Nayak <redacted>

Acked-by: Paul Walmsley <paul@pwsan.com>

Tony, if it isn't too late, could this one be added to your 3.9-rc
fixes
series?

Looks like we missed this so far.

Tony, can you merge this patch for v3.10-rc ?

Oops, sorry somehow this did not make it. I'll apply it to omap-for-v3.10/fixes
with cc: stable flag.

Regards,

Tony