On 15/05/13 21:25, Stephen Boyd wrote:
On 05/15/13 06:41, James Hogan wrote:
quoted
Each place where round_rate() is called, determine_rate is checked first
and called in preference, passing NULL to the new parent argument if not
needed (e.g. in __clk_round_rate).
That's annoying. Even if we don't care about the pointer in
clk_round_rate(), this requires the ops to check for NULL before
assigning the pointer. Why not just pass an unused pointer that the ops
can assign all the time?
True, I'll fix that.
With the above change you can add
Reviewed-by: Stephen Boyd <redacted>
Thanks for taking the time to review it.
Cheers
James