Thread (126 messages) flat view 126 messages, 6 authors, 2013-06-11

[PATCH 34/39] dmaengine: ste_dma40: Convert data_width from register bit format to value

From: Linus Walleij <hidden>
Date: 2013-05-30 09:01:40
Also in: linux-crypto, lkml

On Wed, May 15, 2013 at 11:51 AM, Lee Jones [off-list ref] wrote:
When a DMA client requests and configures a DMA channel, it requests
data_width in Bytes. The DMA40 driver then swiftly converts it over to
the necessary register bit value. Unfortunately, for any subsequent
calculations we have to shift '1' by the bit pattern (1 << data_width)
times to make any sense of it.

This patch flips the semantics on its head and only converts the value
to its respective register bit pattern when writing to registers. This
way we can use the true data_width (in Bytes) value.

Cc: Vinod Koul <redacted>
Cc: Dan Williams <redacted>
Cc: Per Forlin <redacted>
Cc: Rabin Vincent <redacted>
Signed-off-by: Lee Jones <redacted>
Patch applied with what I interpret as Vinod's ACK
("okay..." statement on last reply.)

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help