Thread (2 messages) 2 messages, 2 authors, 2013-05-17

[PATCH v5] ARM:dts:omap4-panda: Update the LED support for the panda DTS

From: nm@ti.com (Nishanth Menon)
Date: 2013-05-17 13:34:50
Also in: linux-devicetree, linux-omap, lkml

On 08:21-20130517, Dan Murphy wrote:
[...]
May be others with better DT experience can help here..
but here is a trick to reduce dts file changes:
quoted hunk ↗ jump to hunk
diff --git a/arch/arm/boot/dts/omap4-panda-es.dts b/arch/arm/boot/dts/omap4-panda-es.dts
index f1d8c21..08d2e38 100644
--- a/arch/arm/boot/dts/omap4-panda-es.dts
+++ b/arch/arm/boot/dts/omap4-panda-es.dts
@@ -34,3 +34,37 @@
 		0x5e 0x100	/* hdmi_sda.hdmi_sda INPUT | MODE 0 */
 		>;
 };
+
+&omap4_pmx_core {
+	led_gpio_pins: gpio_led_pmx {
+		pinctrl-single,pins = <
+			0xb6 0x3	/* gpio_110 OUTPUT | MODE 3 */
+		>;
+	};
+};
+
+&led_wkgpio_pins {
+	pinctrl-single,pins = <
+		0x1c 0x3	/* gpio_wk8 OUTPUT | MODE 3 */
+	>;
+};
+
+&leds {
+	compatible = "gpio-leds";
+	pinctrl-names = "default";
Normally, override  will either add (if new param) OR replace (if same param)
	So the above two are superfluous.
+	pinctrl-0 = <
+		&led_gpio_pins
+		&led_wkgpio_pins
+	>;
These are needed
+
+	heartbeat {
+		label = "pandaboard::status1";
can drop this
+		gpios = <&gpio4 14 0>;
needed
+		linux,default-trigger = "heartbeat";
can be dropped
+	};
+	mmc {
+		label = "pandaboard::status2";
could be dropped
+		gpios = <&gpio1 8 0>;
needed
+		linux,default-trigger = "mmc0";
could be dropped.

-- 
Regards,
Nishanth Menon
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help