Thread (42 messages) 42 messages, 7 authors, 2013-05-24

Lifecycle

  1. Posted "Michael S. Tsirkin" <mst@redhat.com>

[PATCH v2 08/10] tile: uaccess s/might_sleep/might_fault/

From: mst@redhat.com (Michael S. Tsirkin)
Date: 2013-05-16 11:18:41
Also in: kvm, linux-arch, linux-mm, linuxppc-dev, lkml
Subsystem: the rest · Maintainer: Linus Torvalds

The only reason uaccess routines might sleep
is if they fault. Make this explicit.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 arch/tile/include/asm/uaccess.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/tile/include/asm/uaccess.h b/arch/tile/include/asm/uaccess.h
index 8a082bc..e4d44bd 100644
--- a/arch/tile/include/asm/uaccess.h
+++ b/arch/tile/include/asm/uaccess.h
@@ -442,7 +442,7 @@ extern unsigned long __copy_in_user_inatomic(
 static inline unsigned long __must_check
 __copy_in_user(void __user *to, const void __user *from, unsigned long n)
 {
-	might_sleep();
+	might_fault();
 	return __copy_in_user_inatomic(to, from, n);
 }
 
-- 
MST
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help