Thread (21 messages) 21 messages, 3 authors, 2013-05-12

[PATCH -v10 09/11] arm, prepare reboot_mode for moving to generic kernel code.

From: Russell King - ARM Linux <hidden>
Date: 2013-05-11 19:11:30
Also in: lkml

Please, stop this idiotic incomprehensible jargon.

On Sat, May 11, 2013 at 08:47:28AM -0700, H. Peter Anvin wrote:
By the way, do we really need Yoda programming here?

Russell King - ARM Linux [off-list ref] wrote:
quoted
On Sat, May 11, 2013 at 06:57:25AM -0500, Robin Holt wrote:
quoted
This patch prepares for the moving the parsing of reboot= to the
generic
quoted
kernel code by making reboot_mode into a more generic form.

Signed-off-by: Robin Holt <redacted>
To: Andrew Morton <akpm@linux-foundation.org>
To: Russell King <redacted>
Cc: Russ Anderson <redacted>
Cc: Robin Holt <redacted>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Guan Xuetao <redacted>
Cc: Linux Kernel Mailing List <redacted>
Cc: the arch/x86 maintainers <x86@kernel.org>
Cc: Arm Mailing List <redacted>
Almost-but-not-quite-Acked-by: Russell King
[off-list ref] :)
quoted
diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
index f219703..92b47df 100644
--- a/arch/arm/kernel/process.c
+++ b/arch/arm/kernel/process.c
@@ -174,14 +174,14 @@ void arch_cpu_idle(void)
 		default_idle();
 }
 
-static char reboot_mode = 'h';
+enum reboot_mode reboot_mode = REBOOT_HARD;
 
-int __init reboot_setup(char *str)
+static int __init reboot_setup(char *str)
 {
-	reboot_mode = str[0];
+	if ('s' == str[0])
+		reboot_mode = REBOOT_SOFT;
Remember we talked about the 'gpio' mode as well, so you also need here
+	if ('g' == str[0])
	reboot_mode = REBOOT_GPIO;
-- 
Sent from my mobile phone. Please excuse brevity and lack of formatting.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help