[RFC 23/42] drivers/spi: don't check resource with devm_ioremap_resource
From: Stephen Warren <hidden>
Date: 2013-05-10 16:37:49
Also in:
linux-samsung-soc, linux-spi, linux-tegra, lkml
On 05/10/2013 02:17 AM, Wolfram Sang wrote:
devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver.
quoted hunk
diff --git a/drivers/spi/spi-tegra114.c b/drivers/spi/spi-tegra114.c
- r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!r) {
- dev_err(&pdev->dev, "No IO memory resource\n");
- ret = -ENODEV;
- goto exit_free_master;
- }
tspi->phys = r->start;
+ r = platform_get_resource(pdev, IORESOURCE_MEM, 0);The tspi->phy assignment is broken there now.
quoted hunk
diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slink.c
- r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!r) {
- dev_err(&pdev->dev, "No IO memory resource\n");
- ret = -ENODEV;
- goto exit_free_master;
- }
tspi->phys = r->start;
+ r = platform_get_resource(pdev, IORESOURCE_MEM, 0);Same here.