[PATCH v4 3/3] ARM: mach-shmobile: r8a7740: Setup the serial devices using DT
From: arnd@arndb.de (Arnd Bergmann)
Date: 2013-03-05 19:22:02
Also in:
linux-serial, linux-sh
From: arnd@arndb.de (Arnd Bergmann)
Date: 2013-03-05 19:22:02
Also in:
linux-serial, linux-sh
On Tuesday 05 March 2013, Bastian Hecht wrote:
2013/3/4 Arnd Bergmann [off-list ref]:quoted
On Monday 04 March 2013 17:20:54 Bastian Hecht wrote:quoted
+ sci at e6c40000 { + compatible = "renesas,sci-SCIFA-uart"; + interrupt-parent = <&intca>; + reg = <0xe6c40000 0x100>; + interrupts = <0x0c00>, <0x0c00>, <0x0c00>, <0x0c00>; + cell-index = <0>; + renesas,scscr = <0x30>; + renesas,scbrr-algo-id = <4>; + renesas,autoconf; + };The default name for a uart is "serial", I would recommend sticking to that by convention. You may also want to add an "aliases" node somewhere, to define which port should get which logical device number on a given board.Switched to "...-serial".
I actually meant the name, not the "compatible" value. For compatible, either version is fine with me. What I think you should change though is renaming "sci at e6c40000" to "serial at e6c40000".
About the aliases: Would I need to add that now, or can we postpone that?
No hurry for that. It's just a feature that comes in very handy, but not all platforms implement it. Arnd