[PATCH 1/2] arm: omap2: mux: fix debugfs file permission
From: tony@atomide.com (Tony Lindgren)
Date: 2013-03-04 19:18:31
Also in:
linux-omap
From: tony@atomide.com (Tony Lindgren)
Date: 2013-03-04 19:18:31
Also in:
linux-omap
* Felipe Balbi [off-list ref] [130219 02:28]:
OMAP's debugfs interface creates one file for each signal in the mux table, such file provides a read method but didn't provide read permission. Fix it. Signed-off-by: Felipe Balbi <redacted>
Heh indeed, although read still seems to work without it. Applying into omap-for-v3.9/fixes. Regards, Tony
--- arch/arm/mach-omap2/mux.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)diff --git a/arch/arm/mach-omap2/mux.c b/arch/arm/mach-omap2/mux.c index 6a217c9..03fa4f4 100644 --- a/arch/arm/mach-omap2/mux.c +++ b/arch/arm/mach-omap2/mux.c@@ -739,8 +739,9 @@ static void __init omap_mux_dbg_create_entry( list_for_each_entry(e, &partition->muxmodes, node) { struct omap_mux *m = &e->mux; - (void)debugfs_create_file(m->muxnames[0], S_IWUSR, mux_dbg_dir, - m, &omap_mux_dbg_signal_fops); + (void)debugfs_create_file(m->muxnames[0], S_IWUSR | S_IRUGO, + mux_dbg_dir, m, + &omap_mux_dbg_signal_fops); } }-- 1.8.1.rc1.5.g7e0651a