Thread (3 messages) 3 messages, 2 authors, 2013-03-14

[PATCH] mmc: mxcmmc: DT support

From: agust@denx.de (Anatolij Gustschin)
Date: 2013-03-14 15:50:48
Also in: linux-devicetree, linux-mmc

On Mon, 25 Feb 2013 19:28:05 +0100
Markus Pargmann [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Adding devicetree support for imx21-mmc and imx31-mmc. Based on generic
gpio helper functions by Guennadi and generic DMA devicetree bindings.

Signed-off-by: Markus Pargmann <redacted>
---
 .../devicetree/bindings/mmc/fsl-imx-mmc.txt        | 24 +++++++
 drivers/mmc/host/mxcmmc.c                          | 80 +++++++++++++++++-----
 2 files changed, 86 insertions(+), 18 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/mmc/fsl-imx-mmc.txt
diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-mmc.txt b/Documentation/devicetree/bindings/mmc/fsl-imx-mmc.txt
new file mode 100644
index 0000000..a5ab662
--- /dev/null
+++ b/Documentation/devicetree/bindings/mmc/fsl-imx-mmc.txt
@@ -0,0 +1,24 @@
+* Freescale Secure Digital Host Controller for i.MX1/2 series
shouldn't it be "... for i.MX2/3 series"?

...
+	if (!host->pdata) {
+		host->dma = of_dma_request_slave_channel(pdev->dev.of_node,
+				"rx-tx");
please use dma_request_slave_channel(&pdev->dev, "rx-tx")
here. of_dma_request_slave_channel() is not exported for
modules, building the driver as a module will fail.

Thanks,

Anatolij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help