Thread (4 messages) 4 messages, 3 authors, 2013-03-29

Bug in ks8851.c

From: davem@davemloft.net (David Miller)
Date: 2013-03-29 19:43:54
Also in: lkml, netdev

From: Max.Nekludov@us.elster.com
Date: Fri, 29 Mar 2013 19:27:36 +0400
Denis,
here is patch with commit message:

Subject: [PATCH] Fix bug in ks8851 driver

According to the Datasheet (page 52):
15-12 Reserved
11-0 RXBC Receive Byte Count
This field indicates the present received frame byte size.

The code has a bug:
                 rxh = ks8851_rdreg32(ks, KS_RXFHSR);
                 rxstat = rxh & 0xffff;
                 rxlen = rxh >> 16; // BUG!!! 0xFFF mask should be applied

Signed-off-by: Max Nekludov <redacted>
Applied and queued up for -stable, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help