[PATCH v3 1/7] USB: EHCI: make ehci-orion a separate driver
From: stern@rowland.harvard.edu (Alan Stern)
Date: 2013-03-29 17:49:17
Also in:
lkml
On Thu, 28 Mar 2013, Arnd Bergmann wrote:
From: Manjunath Goudar <redacted> Separate the Orion host controller driver from ehci-hcd host code into its own driver module because of following reason.
... On the whole this patch is good.
quoted hunk ↗ jump to hunk
--- a/drivers/usb/host/Kconfig +++ b/drivers/usb/host/Kconfig@@ -163,6 +163,16 @@ config USB_EHCI_HCD_OMAP Enables support for the on-chip EHCI controller on OMAP3 and later chips. +config USB_EHCI_HCD_ORION + tristate "Support for Marvell EBU on-chip EHCI USB controller" + depends on USB_EHCI_HCD && PLAT_ORION + default y + ---help--- + Enables support for the on-chip EHCI controller on Marvell's + embedded ARM SoCs, including Orion, Kirkwood, Dove, Armada XP, + Armada 370. This is different from the EHCI implementation + on Marvell's mobile PXA and MMP SoC, see USB_EHCI_MV for those.
I don't know about this last phrase. When someone is running "make menuconfig", for example, what shows up is the symbol's description, not the symbol's name. That person would see "EHCI support for Marvell on-chip controller", not "USB_EHCI_MV". In fact, shouldn't the description for USB_EHCI_MV be changed too, to make it more distinct from this one? All the code changes are fine. Alan Stern