[PATCH 1/6] platform-drivers: msm: add single-wire serial bus interface (SSBI) driver

Sekhar Nori [off-list ref] writes:

On 3/7/2013 11:31 AM, Greg Kroah-Hartman wrote:

quoted

On Wed, Mar 06, 2013 at 09:20:45PM -0800, David Brown wrote:

quoted

Greg Kroah-Hartman [off-list ref] writes:

quoted

On Wed, Mar 06, 2013 at 04:29:42PM -0800, David Brown wrote:

quoted

+menu "Qualcomm MSM SSBI bus support"
+	depends on ARCH_MSM

Why?

In the sense that ARCH_MSM are the only devices that ever were, or ever
will be made with this device.  It doesn't strictly depend on it, but do
we want to clutter the config for everything else.

It's not "clutter".  You want me to build this on other platforms, to
catch api and other types of build breakages.  This is the way for
almost all Linux drivers.

Not having a depends on helps build coverage, but I have seen
objections to showing up irrelevant configurations to users (of x86 for
example). See one here from Linus for OMAP_OCP2SCP

http://lkml.indiana.edu/hypermail/linux/kernel/1210.0/00785.html

If this case is different, I am not sure why.

This was, in fact, the reason I put the dependency there.  I found it a
little annoying being asked about a bunch of OMAP devices when building
the x86 kernel.  At least they weren't cancer curing options (default
y).

David

-- 
sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation