[PATCH] i2c: Remove unneeded xxx_set_drvdata(..., NULL) calls
From: jacmet@sunsite.dk (Peter Korsgaard)
Date: 2013-02-17 15:12:31
Also in:
linux-i2c, linux-omap, linuxppc-dev
Possibly related (same subject, not in this thread)
- 2013-02-21 · [PATCH] i2c: Remove unneeded xxx_set_drvdata(..., NULL) calls · Wolfram Sang <hidden>
- 2013-02-18 · [PATCH] i2c: Remove unneeded xxx_set_drvdata(..., NULL) calls · marex@denx.de (Marek Vasut)
- 2013-02-16 · [PATCH] i2c: Remove unneeded xxx_set_drvdata(..., NULL) calls · Jean Delvare <hidden>
- 2013-02-15 · [PATCH] i2c: Remove unneeded xxx_set_drvdata(..., NULL) calls · dianders@chromium.org (Doug Anderson)
quoted
quoted
quoted
quoted
"Doug" == Doug Anderson [off-list ref] writes:
Doug> There is simply no reason to be manually setting the private driver Doug> data to NULL in the remove/fail to probe cases. This is just extra Doug> cruft code that can be removed. Doug> A few notes: Doug> * Nothing relies on drvdata being set to NULL. Doug> * The __device_release_driver() function eventually calls Doug> dev_set_drvdata(dev, NULL) anyway, so there's no need to do it Doug> twice. Doug> * I verified that there were no cases where xxx_get_drvdata() was Doug> being called in these drivers and checking for / relying on the NULL Doug> return value. Doug> This could be cleaned up kernel-wide but for now just take the baby Doug> step and remove from the i2c subsystem. Doug> Reported-by: Wolfram Sang [off-list ref] Doug> Reported-by: Stephen Warren [off-list ref] Doug> Signed-off-by: Doug Anderson [off-list ref] For i2c-ocores.c + i2c-mux-gpio.c: Acked-by: Peter Korsgaard <jacmet@sunsite.dk> -- Bye, Peter Korsgaard