Thread (21 messages) flat view 21 messages, 5 authors, 2013-02-08
DORMANTno replies

[PATCH v2 2/2] ARM: uncompress debug support for multiplatform build

From: Russell King - ARM Linux <hidden>
Date: 2013-02-08 12:59:39

On Thu, Feb 07, 2013 at 01:04:36PM +0800, Shawn Guo wrote:
quoted hunk ↗ jump to hunk
=== omap ===

  AS      arch/arm/boot/compressed/debug.o
  LD      arch/arm/boot/compressed/vmlinux
`.data' referenced in section `.text' of arch/arm/boot/compressed/debug.o: defined in discarded section `.data' of arch/arm/boot/compressed/debug.o
make[3]: *** [arch/arm/boot/compressed/vmlinux] Error 1

The following change moving the variables out of stack section seems
fixing the failure, but I'm not quite sure if it works.

8<---
diff --git a/arch/arm/mach-omap2/include/mach/debug-macro.S b/arch/arm/mach-omap2/include/mach/debug
index cfaed13..7b2877e 100644
--- a/arch/arm/mach-omap2/include/mach/debug-macro.S
+++ b/arch/arm/mach-omap2/include/mach/debug-macro.S
@@ -17,11 +17,9 @@

 #define UART_OFFSET(addr)      ((addr) & 0x00ffffff)

-               .pushsection .data
 omap_uart_phys:        .word   0
 omap_uart_virt:        .word   0
 omap_uart_lsr: .word   0
-               .popsection
No, this won't work, because now these variables are located in the text
section which may not be writable.  I don't know what the answer is to
this, but as things stand it's not something that can go into v3.8 until
these problems are addressed (because if it does it _will_ cause
regressions.)

We're basically on the last day of -rc6, so I think it's all too late to
try and get this sorted for this merge window.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help