Thread (3 messages) 3 messages, 3 authors, 2013-02-01
DORMANTno replies

[PATCH] ARM: omap2: gpmc: Remove unneeded of_node_put()

From: tony@atomide.com (Tony Lindgren)
Date: 2013-02-01 21:59:17
Also in: linux-omap

* Jon Hunter [off-list ref] [130125 06:21]:
On 01/25/2013 06:19 AM, Ezequiel Garcia wrote:
quoted
for_each_node_by_name() automatically calls of_node_put() on each
node passed; so don't do it explicitly unless there's an error.

Reported-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Ezequiel Garcia <redacted>
---
 arch/arm/mach-omap2/gpmc.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
index 01ce462..c6255f7 100644
--- a/arch/arm/mach-omap2/gpmc.c
+++ b/arch/arm/mach-omap2/gpmc.c
@@ -1271,9 +1271,10 @@ static int gpmc_probe_dt(struct platform_device *pdev)
 
 	for_each_node_by_name(child, "nand") {
 		ret = gpmc_probe_nand_child(pdev, child);
-		of_node_put(child);
-		if (ret < 0)
+		if (ret < 0) {
+			of_node_put(child);
 			return ret;
+		}
 	}
 
 	return 0;
Acked-by: Jon Hunter <redacted>
Thanks applying into omap-for-v3.9/gpmc.

Tony
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help