Thread (7 messages) 7 messages, 2 authors, 2013-02-14

[PATCH RFC] davinci: poll for sleep completion in resume routine.

From: Vishwanathrao Badarkhe, Manish <hidden>
Date: 2013-02-14 08:52:25
Also in: lkml

Hi Sekhar,

On Thu, Feb 14, 2013 at 12:29:11, Nori, Sekhar wrote:
On 2/14/2013 10:46 AM, Vishwanathrao Badarkhe, Manish wrote:
quoted
Hi Sekhar,

On Thu, Feb 14, 2013 at 09:48:59, Nori, Sekhar wrote:
quoted
Manish,

On 1/31/2013 2:56 PM, Vishwanathrao Badarkhe, Manish wrote:
quoted
As per OMAP-L138 TRM, Software must poll for SLEEPCOMPLETE bit until 
it is set to 1 before clearing SLEEPENABLE bit in DEEPSLEEP register 
in resume routine.
Modifications are as per datasheet:
http://www.ti.com/lit/ug/spruh77a/spruh77a.pdf
See sections 10.10.2.2 and 11.5.21 for more detailed explanation.
Polling for SLEEPCOMPLETE is not required in RTC controlled wake-up which is the mode currently supported (see section 10.10.2.1 of the TRM). Polling for SLEEPCOMPLETE is required for external controlled wake-up which to my knowledge has never been tested. If you have tested this with external controlled wakep-up, then I can consider this patch.
Else, I would like to take it only after externally controlled wake-up is fully tested/supported instead of taking bits and pieces.
Yes, for RTC controlled wakeup, this polling is not required as per section 10.10.2.1.
But if we see in section 10.10.2.2 (Exiting Deep Sleep Mode) step 2, 
When sleep count completes SLEEPCOMPLETE bit gets sets in DEEPSLEEP 
register till that it's not safe to release clock to devices. So If we 
don?t poll for SLEEPCOMPLETE, this delay will not come into picture 
which we actually set while entering deep sleep in case of RTC controlled wakeup (Section 10.10.2.1 step 9).
Please let me know, whether these understanding is correct?
The  delay is coming from hardware. Till SLEEPCOUNT completes, the clock to device is not provided. There is no need to poll for SLEEPCOMPLETE and indeed 10.10.2.2 does not ask for this bit to be polled.
Thanks for your explanation.
Ok, I will test this patch with external controlled wakeup and update you.

Regards, 
Manish Badarkhe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help