Thread (1 message) 1 message, 1 author, 2013-02-12

[PATCH 03/19] ARM: msm: proc_comm_boot_wait should not be __init

From: Olof Johansson <hidden>
Date: 2013-02-12 01:42:54
Also in: linux-arm-msm, lkml

On Fri, Jan 25, 2013 at 10:16:31AM -0800, David Brown wrote:
Arnd Bergmann [off-list ref] writes:
quoted
msm_smd_probe is a driver probe function and may get
called after the __init time, so it must not call
any __init function, as the link-time warning reports.
Take away the __init annotation on proc_comm_boot_wait
to fix this.

Without this patch, building msm_defconfig results in:

WARNING: vmlinux.o(.text+0xb048): Section mismatch in reference from the function msm_smd_probe() to the function .init.text:proc_comm_boot_wait()
The function msm_smd_probe() references
the function __init proc_comm_boot_wait().
This is often because msm_smd_probe lacks a __init
annotation or the annotation of proc_comm_boot_wait is wrong.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: David Brown <redacted>
Cc: Bryan Huntsman <redacted>
Cc: Daniel Walker <redacted>
Cc: linux-arm-msm at vger.kernel.org
---
 arch/arm/mach-msm/proc_comm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Arnd, you're welcome to pull this into your tree:
Acked-by: David Brown <redacted>

I don't forsee any conflicts with upcoming patches.
Applied.


-Olof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help