Thread (17 messages) 17 messages, 5 authors, 2013-02-10
STALE4870d

[PATCH 6/6] ARM: integrator: ensure ap_syscon_base is initialised when !CONFIG_MMU

From: Olof Johansson <hidden>
Date: 2013-01-31 22:56:30

On Thu, Jan 31, 2013 at 10:34:17PM +0000, Will Deacon wrote:
Hi Linus,

On Thu, Jan 31, 2013 at 08:21:04PM +0000, Linus Walleij wrote:
quoted
On Wed, Jan 30, 2013 at 3:27 PM, Will Deacon [off-list ref] wrote:
quoted
When running on Integrator/AP using atags, ap_syscon_base is initialised
in ->map_io, which isn't called for !MMU platforms.
Oh hm. Haha apparently there is one guy with more bizarre hobbies
than myself, you're making me feel un-geeky... ;-)
Ha! Unfortunately, I only have one core-tile otherwise you could have one to
help you feel less left-out :)
quoted
quoted
Instead, initialise the pointer in ->machine_init, as we do when booting
with device-tree.
I was trying to figure out if there is some case where we need it earlier
but apparently not so.

Acked-by: Linus Walleij <redacted>
Cheers!
quoted
Maybe you should send this oneliner directly to the ARM SoC
people?
[adding Olof and Arnd] Is it worth sending a pull request containing a
single patch, or can this patch just be picked directly?
Definitely ok to just send the patch like this. However -- where was
the breakage introduced, i.e.  what should we apply the fix to?


-Olof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help